Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behavior of setting up simulation is not right #5

Closed
sbillinge opened this issue Jan 27, 2016 · 2 comments
Closed

behavior of setting up simulation is not right #5

sbillinge opened this issue Jan 27, 2016 · 2 comments

Comments

@sbillinge
Copy link
Member

The activity that is called start_beamtime() in simsetup.xpdsim needs to be renamed to something like setup_sim to avoid confusion with start_beamtime in xpdAcq

the behavior of setup_sim should be

  1. check if directory ./xpdUser exists. If yes, pass, if no, create it.
  2. check if directory ./config (or whatever it is called) exists. If yes, pass, if no, create it.

OK, I see what you are doing. Maybe we should stick with this approach, though I want to change the behavior of start_beamtime in xpdAcq and it is better if we just change it in one place.

Then we need another start_beamtime() function that is either actually run from xpdAcq as it would be at XPD, or is an xpdsim version that behaves the same. My preference would be that it is run from xpdAcq

@chiahaoliu
Copy link
Collaborator

Yes, I agree with the idea of calling start_beamtime() only from xpdacq so that it is easier to maintain and that is also the way we might use in real beamtime. I put start_beamtime() into xpdsim just to make xpdsim a self-consistent package but it might not be necessary.

I will change the instruction in INSTALLATION and README right away.

@sbillinge
Copy link
Member Author

we have a new workflow now, so I iwll just close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants