You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The activity that is called start_beamtime() in simsetup.xpdsim needs to be renamed to something like setup_sim to avoid confusion with start_beamtime in xpdAcq
the behavior of setup_sim should be
check if directory ./xpdUser exists. If yes, pass, if no, create it.
check if directory ./config (or whatever it is called) exists. If yes, pass, if no, create it.
OK, I see what you are doing. Maybe we should stick with this approach, though I want to change the behavior of start_beamtime in xpdAcq and it is better if we just change it in one place.
Then we need another start_beamtime() function that is either actually run from xpdAcq as it would be at XPD, or is an xpdsim version that behaves the same. My preference would be that it is run from xpdAcq
The text was updated successfully, but these errors were encountered:
Yes, I agree with the idea of calling start_beamtime() only from xpdacq so that it is easier to maintain and that is also the way we might use in real beamtime. I put start_beamtime() into xpdsim just to make xpdsim a self-consistent package but it might not be necessary.
I will change the instruction in INSTALLATION and README right away.
The activity that is called start_beamtime() in simsetup.xpdsim needs to be renamed to something like setup_sim to avoid confusion with start_beamtime in xpdAcq
the behavior of setup_sim should be
OK, I see what you are doing. Maybe we should stick with this approach, though I want to change the behavior of start_beamtime in xpdAcq and it is better if we just change it in one place.
Then we need another start_beamtime() function that is either actually run from xpdAcq as it would be at XPD, or is an xpdsim version that behaves the same. My preference would be that it is run from xpdAcq
The text was updated successfully, but these errors were encountered: