Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom script naming convention #226

Closed
trickiegt opened this issue Apr 9, 2024 · 3 comments
Closed

custom script naming convention #226

trickiegt opened this issue Apr 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@trickiegt
Copy link

Trying out your software today - very nice!
Found an issue when naming a custom script with a '/' -- causes connecting to a shell to crash -- cant find script

Made a simple script that does apt-update and apt-upgrade -y ... called it update / upgrade
Enabled Bring to all compatible shells
Attempt connect to shell and get the following error

Process returned exit code 1:
-bash: line 20: /tmp/xpipe/root/scripts/bash/update_/_upgrade.sh: No such file or directory

renaming the file to update-and-upgrade fixes the error, just bringing it to your attention

@crschnick
Copy link
Contributor

Whoops, yeah seems like I forgot about that part. I was primarily focused on escaping all characters properly that I didn't replace any file system incompatible ones. Will be fixed in the next release

@crschnick crschnick added the bug Something isn't working label Apr 9, 2024
@crschnick
Copy link
Contributor

I think in general I should emphasize somewhere that the name you give the script is used as the actual filename. So if you are looking to create a portable script where you can have quick access to it everywhere, choosing a short but recognizable name is better than a fancy display name. Because in the end you just want to call myscript.sh.

@crschnick
Copy link
Contributor

This is now fixed in 9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants