Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Notebooks are not saved #11

Open
klezm opened this issue Mar 30, 2022 · 5 comments
Open

Jupyter Notebooks are not saved #11

klezm opened this issue Mar 30, 2022 · 5 comments

Comments

@klezm
Copy link

klezm commented Mar 30, 2022

I could not use this extension with any Jupyter notebook. For other files it worked though.

@neriyaco
Copy link
Member

Hi, can you send a reproduce this issue?

@klezm
Copy link
Author

klezm commented Apr 13, 2022

I installed the Extension, changed something inside a jupyter notebook saved it and could not see any history. With e.g. a python file it worked. I tried it again after restarting VSCode, but the issue persisted.

@neriyaco
Copy link
Member

neriyaco commented Nov 8, 2022

Sorry for the very late response, as mentioned here there is no onWillSaveNotebookDocument event.
I will try to find a solution for that.
It might take some time though as I have to do research about notebooks in general.

@klezm
Copy link
Author

klezm commented Nov 8, 2022

VSCode has a built-in file history by now which I am happy with: https://code.visualstudio.com/updates/v1_66#_local-history

@neriyaco
Copy link
Member

neriyaco commented Nov 8, 2022

Yes I know, that's why I left this extension.
I will keep this issue open as I got back working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants