New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify expand-text and encoding #561
Comments
IMHO better to stay consistent and not get messy. So yes, if you want to specify an encoding you have to set |
Fair enough. Alternatively, we could just say that it's ignored. Not sure what's easier/least confusing. |
Opinions, folks? |
Sorry, need to do some research to see what we are talking about. I guess it is
I think this will turn out to be a difficult case for developers and result in unnecessary errors because I have an @expand-text somewhere in my pipeline. Turn it off is no big deal as @eriksiegel said, but remembering that I have to turn of is. So my tendency would be @ndw 's suggestion: Be friendly and ignore @expand-text (whatever value it has). |
It's worse than that. The default value is true, so if you specify an encoding on an inline, you must always add an expand-text attribute to turn it off. I think ignoring it when encoding is specified is harmless (base64 encoded text will never include curly braces anyway). |
@ndw +1 |
Second thought: I think you are right, but then the whole point of "@expand-text" anywhere was useless: @expand-text="true" does not change anything (because it defaults to true) and @expand-text="false" is useless for the same reason. |
Sorry @xml-project , what do you mean? |
As far as I understand it, we have @expand-text anywhere, but it is useless, because @expand-text on p:inline always defaults to "true". Doesn't this mean, that any setting of @expand-text='false' on a parent is overwritten by p:inline? |
“Defaults to true” should be interpreted as: If |
Yes, this was the behaviour I would like to see. But I lost track of the discussion on expand-text, so I understood Norm's comment wrong. |
I think it's spec'd that way now. There's no mention of So putting If that's not what it says, that's what I think it should say. |
@ndw +1
|
Ah, I see how that was misleading. The particular pipeline that I was writing had only one inline and that was encoded. So there was no reason to mention expand-text, but I still had to set it explicitly false. In a pipeline where there was no text to expand that seemed annoying. Do we have consensus that:
|
yes to 1. (I just checked the current prose, “If it has the value ‘ |
ad 1: In @gimsieke I trust. |
It's an error if expand-text is true and an encoding is specified. But expand-text defaults to true. Perhaps we should say that it defaults to true unless there's an encoding specified. But that's kind of messy.
The text was updated successfully, but these errors were encountered: