Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treatment of @visibility when the element is not child of p:library #767

Closed
xml-project opened this Issue Feb 19, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@xml-project
Copy link
Contributor

xml-project commented Feb 19, 2019

For p:option and p:variable we say that it is an error, to declare visibility='private'when the p:option or p:variable is not a child of a p:library. (XS:0093)

But for the same attribute on p:declare-step we say:

If the p:declare-step is not a child of a p:library the attribute has no effect and is ignored.

I think this different treatment is confusing and we should find a uniform way to deal with this problem: Either error in all cases or ignored in all cases.

Did I miss something?

@eriksiegel

This comment has been minimized.

Copy link
Contributor

eriksiegel commented Feb 19, 2019

No preference for how to deal with this

@ndw

This comment has been minimized.

Copy link
Contributor

ndw commented Feb 21, 2019

Per 21 Feb editor's meeting, just ignore it.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Mar 3, 2019

Fixed with pr #781

@xml-project xml-project closed this Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.