Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert filters to jsonify for zarr #225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kthyng
Copy link

@kthyng kthyng commented Aug 17, 2023

  • included a new test for this that fails without the new behavior

This PR closes #223

@kthyng
Copy link
Author

kthyng commented Aug 18, 2023

It looks like this run was canceled, not that it failed. Is that right?

@abkfenris
Copy link
Member

Ya, not sure what that was about. I'll see if I can restart it.

@abkfenris
Copy link
Member

Hmm, all the jobs ended early again. Two again are marked as failed but show canceled, and the rest are canceled. Not sure what's going on with that.

@abkfenris
Copy link
Member

I can run py.test locally and have it pass, but I can't test against the whole matrix while I'm on plane wifi.

@ocefpaf
Copy link

ocefpaf commented Aug 19, 2023

You need to add a fail-fast: false to force everything to run. Otherwise GHA will cancel all tests as soon as the first one fails.

@kthyng
Copy link
Author

kthyng commented Aug 21, 2023

@abkfenris Should I make that change to the github workflow in this PR?

@abkfenris
Copy link
Member

Ya, we can try that, but I'm not certain that it will actually fix the underlying issue. I tried running things again yesterday and it still is showing two jobs as failed, but the logs of all jobs say canceled.

https://github.com/xpublish-community/xpublish/actions/runs/5894225786?pr=225
image

It sounds like there may be some resource contention issues, though we've had the same workflow run successfully on other PRs.

I can sometimes get a single job to pass https://github.com/xpublish-community/xpublish/actions/runs/5894225786/job/16109245196?pr=225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Object of type Shuffle is not JSON serializable
3 participants