Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpublish as a jupyverse plugin #98

Open
davidbrochart opened this issue Dec 9, 2021 · 2 comments · May be fixed by #102
Open

xpublish as a jupyverse plugin #98

davidbrochart opened this issue Dec 9, 2021 · 2 comments · May be fixed by #102
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@davidbrochart
Copy link

Jupyverse is a new Jupyter server implementation based on FastAPI and a plugin system. It could be interesting to provide xpublish as an FPS plugin, as it would allow to create a JupyterLab extension for Zarr visualization.

@jhamman
Copy link
Contributor

jhamman commented Feb 10, 2022

@davidbrochart - if you could provide a brief summary of what would have to change in xpublish to support integration with Jupyverse, that would be super helpful here.

@jhamman jhamman added enhancement New feature or request help wanted Extra attention is needed labels Feb 10, 2022
@davidbrochart davidbrochart linked a pull request Feb 13, 2022 that will close this issue
@davidbrochart
Copy link
Author

davidbrochart commented Feb 13, 2022

Thanks for pinging me @jhamman.
I opened #102, where I started declaring the routers in base, common and zarr as FPS routers. Nothing much, but with this, after installing xpublish and running jupyverse you should see your endpoints at e.g. http://127.0.0.1:8000/docs#/xpublish.
The serve method doesn't apply, as it will automatically be served by jupyverse. I see the FastAPI app is configured in the _init_app method, we would need to find a way to do that through FPS if it's not already possible.
Of course without calling serve() no actual data will be served, so we would need something like publish_in_jupyter() which would do the equivalent of the dependency overrides, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants