Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intake from 0.7.0 #14

Open
sjordan29 opened this issue Apr 30, 2024 · 1 comment
Open

Update Intake from 0.7.0 #14

sjordan29 opened this issue Apr 30, 2024 · 1 comment

Comments

@sjordan29
Copy link
Collaborator

Tests were failing with intake (2.0.5, but tests have not been run in a while, so not sure what version triggers this issue). Specifying intake=0.7.0 in dev_environment.yml fixed the issue.

=========================== short test summary info ============================
FAILED tests/test_1_intake_catalog_setup.py::test_catalog_classes - AssertionError: assert False
 +  where False = isinstance(<Intake catalog: test_intake_zarr_catalog>, <class 'intake.readers.entry.Catalog'>)
 +    where <Intake catalog: test_intake_zarr_catalog> = <catalog_to_xpublish.searchers.intake_search.IntakeCatalogSearch object at 0x7fd240036c10>.catalog_object
 +    and   <class 'intake.readers.entry.Catalog'> = intake.Catalog
FAILED tests/test_3_read_from_intake.py::test_read_from_intake - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
ERROR tests/test_5_run_intake_server.py::test_docs - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
ERROR tests/test_5_run_intake_server.py::test_json_endpoint - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
ERROR tests/test_5_run_intake_server.py::test_yaml_endpoint - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
ERROR tests/test_5_run_intake_server.py::test_catalog_endpoints - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
ERROR tests/test_5_run_intake_server.py::test_datasets_endpoints - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
ERROR tests/test_5_run_intake_server.py::test_zarr_endpoints - TypeError: ZarrArraySource.__init__() got an unexpected keyword argument 'consolidated'
============= 2 failed, 11 passed, 40 warnings, 6 errors in 14.77s =============

We may need to eventually make changes to Catalog-To-Xpublish to work with newer releases of intake.

@aufdenkampe
Copy link
Member

@sjordan29, thanks for recognizing that Intake versions were the answer.

It looks like Intake v2 brought some substantial changes and broke quite a bit of backward compatibility. See

Motivation for the changes are probably presented here: https://discourse.pangeo.io/t/sep-27-2023-intake-2-the-future-martin-durant/3706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants