-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-forge recipe for xraylarch #439
Comments
@maurov it's OK with me to try to do this. I gave up maintaining conda packages, though I do sort of help out with existing conda-forge recipes for some packages, but those are relatively easy. I would suggest going through a few development cycles with it before committing to the idea. Personally, I would much rather support It is fine with me to experiment with github workflows. |
@newville thanks for being open to this. I will give it a try and will see how it goes. For now, nothing will change in the Larch distribution. |
@newville I started the pull request of the recipe conda-forge/staged-recipes#23026 (comment) but the automatic bot tells me there is already a conda-forge recipe for xraylarch, so... I am puzzled. Did you do already it? |
Nope, I do not have anything to do with https://github.com/conda-forge/xraylarch-feedstock/ conda-forge appears to have no governance rules about ownership, participation, or even notification of feedstocks. As a result, squatting on existing projects without even notifying upstream developers is actually pretty common: this has happened to me several times before. Conda-forge and maintainers can both plausibly assert that anyone can make any recipe on any channel they like, and then also advocate "conda-forge" as community-developed. It's sort of a systemic problem. But, maybe you want to work with @mrakitin on this. Having multiple "authors" is always a good idea. |
@newville, you are always welcome to join the maintainers' team in the linked conda-forge feedstock. I mentioned it in the past (e.g., via #280). There are guidelines in fact, please check https://conda-forge.org/docs/maintainer/adding_pkgs.html#recipe-maintainer. |
@mrakitin Thanks -- I guess I thought that discussion was about what to include as dependencies in a conda recipe in general and the NSLS-II feedstock. I guess that I forgot that you proposed a The point I was trying (probably poorly!) to make is that while conda-forge sort of claims to be a de-facto standard repository of Python and Python-related (and maybe other scientific computing) packages, from the "conda" point-of-view it is just another "channel", and conda-forge does not do anything specifically to contact, involve, or review who has been developing or maintaining feedstocks. It's really sort of a complaint about conda-forge and their own not-quite-publicly stated claim to be a de-facto standard. |
The feedstock https://github.com/conda-forge/xraylarch-feedstock/ already exists. I've invited @maurov to the maintainers' team. |
@mrakitin thanks for adding me to the maintainers' team. I was not aware of an existing conda-forge package for Larch, this is why I initiated one from scratch. I will check the current recipe and propose a pull request soon. I would like to get uniform conda requirements between the Larch install scripts, github workflows and the conda-forge recipe. Is that fine with you? @newville should we update the documentation to clearly state the possibility to install larch from conda forge? |
@maurov I'm OK with adding this to the docs. I am OK with adding a test using this. I am less OK with removing tests that use I am going to continue to insist that |
@mrakitin I have been trying installing larch via conda-forge lately on various Linux (or Windows WSL) machines and unfortunately it never worked for me! Does it really work for you? |
I put some news here. With the help of @t20100 we are advancing in packaging a working conda-forge/xraylarch-feedstock#25 Related:
@newville, we will make two packages: |
@newville I would like to maintain a conda-forge recipe for
xraylarch
(from PyPI via grayskull). I am ready to make a pull request (to conda-forge):https://github.com/maurov/staged-recipes/blob/xraylarch/recipes/xraylarch/meta.yaml
For those who want to use Larch with Wx (and Jupyter), this would be as simple as
conda/mamba install -c conda-forge xraylarch
. This way we do not need to hard code single conda/mamba packages in.github/workflows
and in the install scripts.Do you have anything against it?
The text was updated successfully, but these errors were encountered: