Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for generate contents in CircleCI #85 #87

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Aug 26, 2019

fixes #85

Due to embed commit id in ./docs/apidocs/template/pkg.tpl, it had output unnecessary diff. So before generating with make, that fixed using sed command to replacing commit id with the one of current ./docs/static/apidocs.html

@u5surf
Copy link
Contributor Author

u5surf commented Aug 26, 2019

Should this diff not check in CI?

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
index b45a62b..87a94b5 100644
--- a/config/rbac/role.yaml
+++ b/config/rbac/role.yaml
@@ -12 +12 @@ rules:
-  - events
+  - configmaps
@@ -18 +18 @@ rules:
-  - configmaps
+  - events

@otto-von-bivouac
Copy link
Member

Thank you for your contribution @u5surf, super awesome!

You're right about the rbac/role.yaml, should be included in the PR.
Also, go modules needs to be updated which are reported by run_doc_tests.

Could you please address those? Then we're good to merge.

Once again, thank you for fixing this, much appreciated!

Copy link
Member

@otto-von-bivouac otto-von-bivouac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@otto-von-bivouac otto-von-bivouac merged commit 790baa7 into kubestone:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanity check for generated content in CircleCI
2 participants