Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase header maximum character length #152

Open
XP1 opened this issue Aug 27, 2017 · 4 comments
Open

Increase header maximum character length #152

XP1 opened this issue Aug 27, 2017 · 4 comments

Comments

@XP1
Copy link

XP1 commented Aug 27, 2017

There needs to be a larger maximum character length for headers. HTTrack terminates and complains that the user-agent string and header lines are too long.

"User-agent length too long":
https://github.com/xroche/httrack/blob/master/src/htscoremain.c#L2695

if (strlen(argv[na]) >= 126) {
  HTS_PANIC_PRINTF("User-agent length too long");
  htsmain_free();
  return -1;
}

"Header line string too long":
https://github.com/xroche/httrack/blob/master/src/htscoremain.c#L1791

} else if (strlen(argv[na]) >= 256) {
  HTS_PANIC_PRINTF("Header line string too long");
  htsmain_free();
  return -1;
}
@krausekai
Copy link

krausekai commented Jun 5, 2018

Agreed.

This is causing issues with long cookie values for me (up to 700 in length).

@zoness32
Copy link

zoness32 commented Jul 4, 2020

Is this ever going to be fixed?

@overdrivemachines
Copy link

This sucks. How can we get this fixed ourselves? Or is there another way to send long cookies?

@Zerogoki00
Copy link

Zerogoki00 commented May 8, 2024

What a terrible design choice. Will it get fixed?
This makes this feature unusable because websites use a lot of cookies nowadays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants