Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit function declarations in configure logs #250

Closed
hartwork opened this issue Mar 13, 2023 · 1 comment
Closed

Implicit function declarations in configure logs #250

hartwork opened this issue Mar 13, 2023 · 1 comment

Comments

@hartwork
Copy link

hartwork commented Mar 13, 2023

Hi!

This QA issue was brought to my attention at https://bugs.gentoo.org/898834:

 * QA Notice: Found the following implicit function declarations in configure logs:
 *   /var/tmp/portage/www-client/httrack-3.49.4-r1/work/httrack-3.49.4/config.log:985 - strcmp
 *   /var/tmp/portage/www-client/httrack-3.49.4-r1/work/httrack-3.49.4/config.log:992 - exit
 *   /var/tmp/portage/www-client/httrack-3.49.4-r1/work/httrack-3.49.4/config.log:1026 - strcmp
 *   /var/tmp/portage/www-client/httrack-3.49.4-r1/work/httrack-3.49.4/config.log:1033 - exit
 * Check that no features were accidentally disabled.
 * See https://wiki.gentoo.org/wiki/Modern_C_porting.

So there is a risk that e.g. with Clang 16 compilation results will not be as intended/expected.
I do not see direct use of strcmp or exit in configure.ac so this is likely from the m4 files that httrack relies upon. Will need a closer look, I want to start with making the issue known.

Best, Sebastian

@xroche
Copy link
Owner

xroche commented Jan 27, 2024

Fixed in 940bc75

@xroche xroche closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants