Fix const correctness of the API.

Make the API more straightforward for external users by getting the const correctness ... correct.
xrootd · Dec 21, 2017 · d7880bc · d7880bc
1 parent d4cf0c0
commit d7880bc
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/XrdHttp/XrdHttpExtHandler.cc b/src/XrdHttp/XrdHttpExtHandler.cc
@@ -27,21 +27,21 @@
 #include "XrdHttpProtocol.hh"
 
 /// Sends a basic response. If the length is < 0 then it is calculated internally
-int XrdHttpExtReq::SendSimpleResp(int code, char* desc, char* header_to_add, char* body, long long int bodylen)
+int XrdHttpExtReq::SendSimpleResp(int code, const char* desc, const char* header_to_add, const char* body, long long int bodylen)
 {
   if (!prot) return -1;
 
   return prot->SendSimpleResp(code, desc, header_to_add, body, bodylen);
 }
 
-int XrdHttpExtReq::StartChunkedResp(int code, char *desc, char *header_to_add)
+int XrdHttpExtReq::StartChunkedResp(int code, const char *desc, const char *header_to_add)
 {
   if (!prot) return -1;
 
   return prot->StartChunkedResp(code, desc, header_to_add);
 }
 
-int XrdHttpExtReq::ChunkResp(char *body, long long bodylen)
+int XrdHttpExtReq::ChunkResp(const char *body, long long bodylen)
 {
   if (!prot) return -1;
 

diff --git a/src/XrdHttp/XrdHttpExtHandler.hh b/src/XrdHttp/XrdHttpExtHandler.hh
@@ -62,15 +62,15 @@ public:
   int BuffgetData(int blen, char **data, bool wait);
 
   /// Sends a basic response. If the length is < 0 then it is calculated internally
-  int SendSimpleResp(int code, char *desc, char *header_to_add, char *body, long long bodylen);
+  int SendSimpleResp(int code, const char *desc, const char *header_to_add, const char *body, long long bodylen);
 
   /// Starts a chunked response; body of request is sent over multiple parts using the SendChunkResp
   //  API.
-  int StartChunkedResp(int code, char *desc, char *header_to_add);
+  int StartChunkedResp(int code, const char *desc, const char *header_to_add);
 
   /// Send a (potentially partial) body in a chunked response; invoking with NULL body
   //  indicates that this is the last chunk in the response.
-  int ChunkResp(char *body, long long bodylen);
+  int ChunkResp(const char *body, long long bodylen);
 };
 
 

diff --git a/src/XrdHttp/XrdHttpProtocol.cc b/src/XrdHttp/XrdHttpProtocol.cc
@@ -1221,7 +1221,7 @@ int XrdHttpProtocol::StartSimpleResp(int code, const char *desc, const char *hea
   return 0;
 }
 
-int XrdHttpProtocol::StartChunkedResp(int code, char *desc, char *header_to_add) {
+int XrdHttpProtocol::StartChunkedResp(int code, const char *desc, const char *header_to_add) {
   const std::string crlf = "\r\n";
 
   std::stringstream ss;
@@ -1234,7 +1234,7 @@ int XrdHttpProtocol::StartChunkedResp(int code, char *desc, char *header_to_add)
   return StartSimpleResp(code, desc, ss.str().c_str(), -1);
 }
 
-int XrdHttpProtocol::ChunkResp(char *body, long long bodylen) {
+int XrdHttpProtocol::ChunkResp(const char *body, long long bodylen) {
   const std::string crlf = "\r\n";
   long long chunk_length = bodylen;
   if (bodylen <= 0) {

diff --git a/src/XrdHttp/XrdHttpProtocol.hh b/src/XrdHttp/XrdHttpProtocol.hh
@@ -230,11 +230,11 @@ private:
 
   /// Starts a chunked response; body of request is sent over multiple parts using the SendChunkResp
   //  API.
-  int StartChunkedResp(int code, char *desc, char *header_to_add);
+  int StartChunkedResp(int code, const char *desc, const char *header_to_add);
 
   /// Send a (potentially partial) body in a chunked response; invoking with NULL body
   //  indicates that this is the last chunk in the response.
-  int ChunkResp(char *body, long long bodylen);
+  int ChunkResp(const char *body, long long bodylen);
 
   /// Gets a string that represents the IP address of the client. Must be freed
   char *GetClientIPStr();