python:: client.__version__:: erroneous 'v'

[adriansev]

Hi! Would it be possible to have (return to) strict decimal numbers in the module version?
Currently it is:

>>> print(client.__version__)
v5.0.1

[adriansev]

and for 4.12.4 installed with pip3_install_user xrootd==4.12.4 i get

pip3_install_user xrootd==4.12.4
WARNING: Keyring is skipped due to an exception: Failed to unlock the collection!
Collecting xrootd==4.12.4
  Using cached xrootd-4.12.4.tar.gz (2.6 MB)
  WARNING: Requested xrootd==4.12.4 from https://files.pythonhosted.org/packages/87/06/705ab2671c08473f0175288080ffad73f01f17eec9eb5409e1965163869d/xrootd-4.12.4.tar.gz#sha256=86c5a6dc470dbb1ffafdecee26a5c125e9ecbede16c4b0a7c1104abb37cea518, but installing version 0.0.0
...

python3
Python 3.7.9 (default, Aug 19 2020, 17:05:11)
[GCC 9.3.1 20200408 (Red Hat 9.3.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from XRootD import client
>>> print(client.__version__)
v-

ping @simonmichal

[simonmichal]

Hi @adriansev,

• regarding the v- version, I just backported the respective commit to the stable branch (8f77fe3) my apologies it has not been done earlier

• regarding the version format itself, my understanding is you would like to see 5.0.1 instead of v5.0.1? Yes, certainly that's doable.

[simonmichal]

@adriansev : I'm stripping now the leading v from the __version__ -> 30350cd (also backported to stable branches).

[adriansev]

@simonmichal Great!!! thanks a lot!! in principle the advantage of strictly numeric versions (also easily splittable) is that allow really easy version checking when a downstream application use the different signatures that can happen from version to version in upstream. (as i do for the checking hash when copy).

[simonmichal]

@adriansev : is there anything else that needs to be sorted out, or can we close this one?

[adriansev]

sorry, i forgot about this one, this can be closed (and of course i cannot test it until a release is out :) )