You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi. While trying to run tests for PR #1585 I realized that the tests for the Python bindings are written to be Python 2 only (as of 98d83fb). Doing some quick checks with a rough pass of
2to3 --write .
also show that the examples and tests all contain Python 2 only code.
The bindings/python/examples/ can be easily fixed by just properly applying the print() function.
The bindings/python/tests/ are mostly also just need print() functions but also have some string encoding differences and a breaking xrange vs. range change
I see that there has been some work and care put into ensuring that the Python 2 only code in bindings/python/libs/ is properly guarded, so I think that's fine as is. 👍
To be able to run tests I'm willing to contribute a PR that updates the example and tests code to Python 3, but is there a desire to continue to run the tests for Python 2? I don't know how long the XRootD team plans to support Python 2 as it is now EOL for over a year and there isn't any clear statements in the docs about LTS given that the supported OS part of the docs
Also, if I have this correct, is the https://gitlab.cern.ch/dss/xrootd GitLab mirror used to run the CI. Do you have instructions on how to have contributed PRs run the CI before they get merged so that PRs can link a passing test suite?
The text was updated successfully, but these errors were encountered:
@matthewfeickert : sorry for the late reply, there's no need to keep the tests compatible with Python2, if you could submit a PR that ports them to Python3 it would be great. (Unfortunately we are not able at the moment to run the CI in gitlab for PR.)
Since we will drop support for Python 2.x in XRootD 6.0.0, I'm marking this with that milestone, but will try to port the tests to Python 3.x and add them to run in our CI earlier than that (and mark the correct milestone fixing this later on).
Hi. While trying to run tests for PR #1585 I realized that the tests for the Python bindings are written to be Python 2 only (as of 98d83fb). Doing some quick checks with a rough pass of
also show that the examples and tests all contain Python 2 only code.
bindings/python/examples/
can be easily fixed by just properly applying theprint()
function.bindings/python/tests/
are mostly also just needprint()
functions but also have some string encoding differences and a breakingxrange
vs.range
changexrootd/bindings/python/tests/test_threads.py
Line 31 in 98d83fb
bindings/python/libs/
is properly guarded, so I think that's fine as is. 👍To be able to run tests I'm willing to contribute a PR that updates the example and tests code to Python 3, but is there a desire to continue to run the tests for Python 2? I don't know how long the XRootD team plans to support Python 2 as it is now EOL for over a year and there isn't any clear statements in the docs about LTS given that the supported OS part of the docs
xrootd/README
Lines 12 to 19 in 98d83fb
was added 10 years ago in 2011 and I don't think is accurate anymore.
Also, if I have this correct, is the https://gitlab.cern.ch/dss/xrootd GitLab mirror used to run the CI. Do you have instructions on how to have contributed PRs run the CI before they get merged so that PRs can link a passing test suite?
The text was updated successfully, but these errors were encountered: