Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no OpenFlags.APPEND #1731

Closed
ScottDemarest opened this issue Jul 1, 2022 · 3 comments
Closed

no OpenFlags.APPEND #1731

ScottDemarest opened this issue Jul 1, 2022 · 3 comments

Comments

@ScottDemarest
Copy link

There appears to be no OpenFlags.APPEND and it seems that it was removed. The documentation still lists APPEND as a valid flag. Can it be brought back?

@simonmichal
Copy link
Contributor

@ScottDemarest : we have removed the append flag in XRootD5 from the client because we actually never supported this functionality properly. From what I see it was also never really supported in the bindings, the currentOffset:

uint64_t currentOffset;

is being used only for the readline functionality.

Why do you need the open flag? Is that you used to have it and now you are getting a build error (in this case I would ask you just to remove the flag), or do you need this functionality implemented?

@ScottDemarest
Copy link
Author

I am working on an fsspec implementation for xrootd and append functionality would have been convenient. I have worked around it though and do not need anything more. I only asked because it is listed in the docs at this link https://xrootd.slac.stanford.edu/doc/python/xrootd-python/modules/client/flags.html

@abh3
Copy link
Member

abh3 commented Aug 23, 2022

OK, I am closing this ticket. Indeed, the append flag was added as a place holder but the feature was never implemented. We have removed that flag from the client-side include files to avoid this misunderstanding.

@abh3 abh3 closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants