You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While converting the XrdCl::URL tests to GoogleTest, I noticed that it accepts zero, negative, and big (>65536) port numbers as valid. For example, "root://eospilot.cern.ch:-1", and "root://eospilot.cern.ch:281474976710656" are both considered valid. I also noticed that a URL with parameters, but without a path will be considered invalid, i.e. something like http://localhost:8080?param=value. However, that should likely be considered valid, with path normalized to "/", as that's what the browser does. URLs with empty username and/or password are also rejected, i.e., something like http://:@localhost and http://@localhost. Should these be considered valid? The browser seems to accept them. The final thing is that XrdCl::URL cannot accept passwords that contain the character @ or / in them, but I guess that's not really a bug, even if those are supposedly valid characters for passwords.
The text was updated successfully, but these errors were encountered:
While converting the
XrdCl::URL
tests to GoogleTest, I noticed that it accepts zero, negative, and big (>65536) port numbers as valid. For example,"root://eospilot.cern.ch:-1"
, and"root://eospilot.cern.ch:281474976710656"
are both considered valid. I also noticed that a URL with parameters, but without a path will be considered invalid, i.e. something likehttp://localhost:8080?param=value
. However, that should likely be considered valid, with path normalized to"/"
, as that's what the browser does. URLs with empty username and/or password are also rejected, i.e., something likehttp://:@localhost
andhttp://@localhost
. Should these be considered valid? The browser seems to accept them. The final thing is thatXrdCl::URL
cannot accept passwords that contain the character@
or/
in them, but I guess that's not really a bug, even if those are supposedly valid characters for passwords.The text was updated successfully, but these errors were encountered: