Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XrdHttp - Wrong handling of SSL_Shutdown() in XrdHttpProtocol::Cleanup() #1967

Closed
ccaffy opened this issue Mar 18, 2023 · 1 comment
Closed
Assignees
Milestone

Comments

@ccaffy
Copy link
Contributor

ccaffy commented Mar 18, 2023

We see a lot of messages of SSL_shutdown failed in the logs.

This is due to the following code in XrdHttpProtocol::Cleanup():

if (SSL_shutdown(ssl) != 1) {
      TRACE(ALL, " SSL_shutdown failed");
      ERR_print_errors(sslbio_err);
    }

The documentation of SSL_shutdown says that it is only when the return code of SSL_shutdown() is <0 that there is a fatal error: https://www.openssl.org/docs/man1.0.2/man3/SSL_shutdown.html

I'll therefore change this behaviour.

@ccaffy
Copy link
Contributor Author

ccaffy commented Mar 21, 2023

Done and merged.

@ccaffy ccaffy closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants