Rework from Size animations to Scale animations, add StackAlignment + StackDensity #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-stockx
changed the title
thomas-stockx
changed the title
|
I'm closing this PR as it as deviated from the original package by a substantial amount and would cause too many breaking changes in dependend apps/packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several changes:
Rework to use Scale instead of Size for resizing middle and back cards.
The current Size method worked fine for images, but when embedding text in cards it caused issues do to text wrap as the container was resizing. I've reworked the resizing to use Scale animations instead.
Added Stack Alignment & StackDensity
In the current implementation there's no way to change how the stack looks. Cards are always on top of each other, with the middle and back cards sticking out at the bottom of the widget.
With StackAlignment you can change where the middle and back cards peek out.
With StackDensity you can change how much the middle and back cards stick out.
I've tried to maintain as much similarity to the old (Size) resizing as possible, but it might introduce minor visual changes, so I would flag this as a breaking change.