Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still accepting PR's ? #113

Open
codewise-nicolas opened this issue Sep 7, 2019 · 0 comments
Open

Still accepting PR's ? #113

codewise-nicolas opened this issue Sep 7, 2019 · 0 comments

Comments

@codewise-nicolas
Copy link

Describe the bug
Not a bug. Question: Do you still accept PR's ?
I have added a new function to get the list of devices (very rough) and before I go thru the effort of figuring out how to do a PR, I want to know if you are even accepting them anymore. I appreciate the plugin and so I want to give back.

To Reproduce
Please share the following:

  1. Version of cordovarduino / cordova: Latest github source
  2. Type of board you use and code: not applicable
  3. Type of smartphone you use and code: android/not applicable
  4. Any relevant stuff: None, just thanks.

Expected behavior
I go thru and do a proper git pull and do a PR commit to submit the changes and then they are accepted and added to the main stream code.

Screenshots
not applicable

Additional context
Just a big ol thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant