Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0176 data type of ICE foundation #575

Closed
xdumaine opened this issue Jan 19, 2018 · 6 comments
Closed

XEP-0176 data type of ICE foundation #575

xdumaine opened this issue Jan 19, 2018 · 6 comments

Comments

@xdumaine
Copy link
Contributor

Jingle ICE defines the "foundation" of it's ICE candidate as an unsigned byte in it's schema: https://xmpp.org/extensions/xep-0176.html#schema which does not seem to match the ICE RFC which defines it as a string: https://tools.ietf.org/html/rfc5245#section-15.1

XEP-0176 should change the type foundation string with valid chars A-z, 0-9, +, /

@legastero @fippo @stpeter

@fippo
Copy link
Contributor

fippo commented Jan 19, 2018

see https://xmpp.org/extensions/xep-0371.html#protocol-syntax -- we fixed this there.

@Flowdalic
Copy link
Contributor

So it's just a matter of fixing the schema, replacing

        <xs:attribute name='foundation' type='xs:unsignedByte' use='required'/>

with

        <xs:attribute name='foundation' type='xs:string use='required'/>

?

@fippo
Copy link
Contributor

fippo commented Jan 19, 2018

@Flowdalic there is a bigger issue. 0176 was written against a pre-RFC version of ICE which was in limbo for half a decade before it became RFC 5245

@stpeter
Copy link
Member

stpeter commented Jan 19, 2018

We really should deprecate XEP-0176 and advance XEP-0371. I had some non-related fixes in process but lost track of this work item a few years ago. :(

@fippo
Copy link
Contributor

fippo commented Jan 19, 2018

we made notes in the wiki page...

@stpeter
Copy link
Member

stpeter commented Jan 19, 2018

Yeah, but finding the time and energy to work on it is not so easy. :-) I will try to find my edits this weekend (unfortunately they were to the entire Jingle suite so it was a big changeset).

@xdumaine xdumaine closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@Flowdalic Flowdalic reopened this Apr 4, 2023
@xdumaine xdumaine closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants