Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires MouseX::Foreign optionally #102

Merged
merged 1 commit into from Aug 26, 2019
Merged

Conversation

skaji
Copy link
Member

@skaji skaji commented Aug 26, 2019

#101 (comment)

Note that we cannot use Test::Requires here,
because Test::Requires does "use MouseX::Foreign" (we just want to do "require MouseX::Foreign").

@skaji
Copy link
Member Author

skaji commented Aug 26, 2019

Because t/900_mouse_bugs/021_issue100_sevg.t has circular dependencies in nature,
I think we may want to move it to xt/ directory.

@skaji skaji merged commit 167b9d3 into master Aug 26, 2019
@skaji skaji deleted the optional-MouseX-Foreign branch August 26, 2019 14:45
skaji added a commit that referenced this pull request Aug 26, 2019
Changelog diff is:

diff --git a/Changes b/Changes
index c1ade4c..f8de1cf 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Mouse

 {{$NEXT}}

+v2.5.9 2019-08-26T14:46:49Z
+    - Fix circular dependencies between Mouse and MouseX::Foreign (pghmcfc #102)
+
 v2.5.8 2019-08-25T18:52:19Z
     - Fix segmentation fault which occurs when using MouseX::Foreign and role->apply at the same time (ken39arg #100, #101)
skaji added a commit that referenced this pull request Mar 28, 2020
Changelog diff is:

diff --git a/Changes b/Changes
index f8de1cf..499c482 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Mouse
 
 {{$NEXT}}
 
+v2.5.10 2020-03-28T13:15:57Z
+    - Do not use Fatal (#108)
+
 v2.5.9 2019-08-26T14:46:49Z
     - Fix circular dependencies between Mouse and MouseX::Foreign (pghmcfc #102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant