improves perl 5.8 support #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….8 and Devel::PPPort 3.33+
… deleted elements
skaji
added a commit
that referenced
this pull request
Nov 30, 2017
Changelog diff is:
diff --git a/Changes b/Changes
index 6160d1e7..605d1077 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,15 @@
Revision history for Perl extension Text::Xslate
+{{$NEXT}}
+
+v3.5.0 2017-11-30T15:57:50Z
+ - Migrate to using minil (#179)
+ - Improve perl 5.8 support (#182)
+ - Use version->declare() to declare $VERSION (#182)
+ - Make `prove -br t` work with dot-not-in-INC perls (#184)
+ - Run tests against both XS and pureperl (#185)
+ - Fix typo (anirvan #181)
+
3.4.0 2017-01-20 15:00:00+0900
- Fix tied hash issue(#173)
- Fix encoding issue(#160)
skaji
added a commit
that referenced
this pull request
Nov 30, 2017
Changelog diff is:
diff --git a/Changes b/Changes
index 605d1077..38f53e26 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Perl extension Text::Xslate
{{$NEXT}}
+v3.5.1 2017-11-30T16:09:33Z
+ - Fix packaging issue; explicitly declare version for Text::Xslate::Engine
+
v3.5.0 2017-11-30T15:57:50Z
- Migrate to using minil (#179)
- Improve perl 5.8 support (#182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves perl 5.8 support.
(A) 34d26b1
Currently Xslate cannot be built on perl 5.8 with Devel::PPPort 3.33+.
This commit will fix this.
See also Dual-Life/Devel-PPPort#42
(B) f9258de
Currently t/900_bugs/030_issue71.t fails on perl 5.8.
In recent perl, SvUPGRADE(av, SVt_PVAV) makes the av AvREAL_only,
so that av_fill() frees deleted elements.
https://github.com/Perl/perl5/blob/v5.26.1/sv.c#L1357
https://github.com/Perl/perl5/blob/v5.26.1/av.c#L860-L865
On the other hand, in perl 5.8, SvUPGRADE(av, SVt_PVAV) does NOT make the av AvREAL_only,
so that av_fill() does NOT free deleted elements, and it implies memory leaks.
https://github.com/Perl/perl5/blob/perl-5.8.5/sv.c#L1462-L1476
https://github.com/Perl/perl5/blob/perl-5.8.5/av.c#L767-L772
The commit f9258de makes
newframeAvREAL_only (= AvREIFY_off + AvREAL_on) explicitly.(C) 2e5392a
Use version->declare syntax; otherwise we'll get: