Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

"Allow passing data arguments to modal (fixes #531)" from bootstrap #20

Closed
gavrilyak opened this issue Oct 19, 2012 · 3 comments · Fixed by #21
Closed

"Allow passing data arguments to modal (fixes #531)" from bootstrap #20

gavrilyak opened this issue Oct 19, 2012 · 3 comments · Fixed by #21

Comments

@gavrilyak
Copy link
Contributor

Bootstrap modal added this functionality in implementation of modal.
Original issue - twbs/bootstrap#531
Original commit - twbs/bootstrap@2f3d04b

I wanted to make a pull request, but accidentally committed changes to event bubbles, and do not know how to make a clean pull request now :-(
My commit is here - gavrilyak@2a78d33

@superdweebie
Copy link
Collaborator

@gavrilyak Just change the event bubbles back, do another commit, and then use git interactive rebase to squash the two commits into a single commit - it will make your undesired changes disappear.

@gavrilyak
Copy link
Contributor Author

@superdweebie Thanks for help, your suggestion worked just fine. But then I realized that my patch was too invasive, so I just cloned the repo again and reworked it from scratch.

@superdweebie
Copy link
Collaborator

No problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants