New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup cookie option #9
Setup cookie option #9
Conversation
Looking pretty good so far, I made some feedback. Can you also add some documentation for those ? |
Thanks for checking it out. Feedback has been reflected and the README and example have been updated. The module reference in example is now 0.1.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes to make the doc / API a little simpler (this is nitpicking at this point).
otherwise, really nice work 👍
amazing work on the doc 👏
I have corrected the areas you pointed out. I think it is now much simpler. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, I will run some test when I will be off the train and mark a new release 👍
Hello, @xstevenyung.
Both cookie sessions and redis sessions use cookies, but I was unable to set cookie options, so I added a feature.
Specifically, I wanted to set max-age, http-only, etc.
For example.