Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scripts object from Dictionary<string, string> to KeyedCollection<string, string> #92

Open
xt0rted opened this issue Sep 19, 2022 · 0 comments · May be fixed by #130
Open

Update scripts object from Dictionary<string, string> to KeyedCollection<string, string> #92

xt0rted opened this issue Sep 19, 2022 · 0 comments · May be fixed by #130

Comments

@xt0rted
Copy link
Owner

xt0rted commented Sep 19, 2022

The underlying list of scripts is a Dictionary<string, string> but that doesn't guarantee the scripts will be in the order they're in in the global.json, so switching it to a KeyedCollection<string, string> would be the right thing to do so we can maintain order when using wildcards to run scripts.
@xt0rted xt0rted linked a pull request Dec 4, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use KeyedCollection instead of Dictionary xt0rted/dotnet-run-script
1 participant
@xt0rted