Add add-source as an optional argument to the tooling
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
So I've tried my hand at this, admittedly this is the first time I have created a GitHub Action.
This project doesn't seem to commit in the dist folder, I assume you must have some process outside of this to properly distribute the changes?
The change itself was pretty straight forward, I simply appended to the array if add-sources was passed as an attribute.
I think I got all of the places for version bumping; I assume this follows SemVer, because these changes are backwards compatible it was only bumped to 1.1.0.
Its unclear exactly how this is tested, I can tell you that I have been playing around with the actions in a branch here: https://github.com/aolszowka/ManipulativeReplacer/runs/1270148423 (not sure if you can see the results) tagged to my branch instead of yours.