Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings Not Annotated #170

Open
jherdman opened this issue Nov 13, 2020 · 2 comments · May be fixed by #359
Open

Warnings Not Annotated #170

jherdman opened this issue Nov 13, 2020 · 2 comments · May be fixed by #359

Comments

@jherdman
Copy link

I'm in the middle of introducing Stylelint to a project. In order to smooth things over a little I've set defaultSeverity to "warning", which reports as below, but doesn't issue an error code:

app/styles/utilities/shadow.css
  8:35  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
  8:37  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
  8:39  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 12:35  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 12:37  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 12:39  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 16:33  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 16:35  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 16:37  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 20:33  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 20:35  ⚠  Expected single space after "," in a single-line function   function-comma-space-after
 20:37  ⚠  Expected single space after "," in a single-line function   function-comma-space-after

I'm not seeing these annotations in my build, which would be desirable to encourage teammates to resolve these. Is there a configuration option I'm missing with this action?
@andresriveratoro
Copy link

Are there any plans on adding the option to create annotations on warning?

@xt0rted xt0rted linked a pull request Apr 29, 2022 that will close this issue
Open
@xt0rted
Copy link
Owner

xt0rted commented Apr 29, 2022 •
edited
Loading

I just tried implementing this and ran into issues where if your build output contains errors and warnings then only the first severity level gets matched. This looks to be a limitation of problem matchers so I need to look into this more to see if there's some way to make this work. I also discovered that enabling the env var FORCE_COLOR breaks problem matchers like this one so that needs some additional looking into as well.

ref: actions/runner#1862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Match errors and warnings xt0rted/stylelint-problem-matcher
3 participants
@jherdman @xt0rted @andresriveratoro