Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second Chance cache should not leak memory #1818

Open
refset opened this issue Sep 12, 2022 · 1 comment
Open

Second Chance cache should not leak memory #1818

refset opened this issue Sep 12, 2022 · 1 comment
Labels
1.x bug Something isn't working repro-reqd
Projects
XTDB Development

Comments

@refset
Copy link
Contributor

refset commented Sep 12, 2022 •
edited

Details below are from a dump of an application running normally, but for which an OOM was recently triggered (during long-running queries/exports, and possibly also concurrently with a checkpoint being created). This heat dump is from normal operation...

"Retained Size" descending:
image

"[Number of] Objects" descending:
image

Thank you for the report @FiV0
@refset refset added the bug Something isn't working label Sep 12, 2022
@refset refset added this to Backlog in XTDB Development via automation Sep 12, 2022
@refset refset moved this from Backlog to Selected in XTDB Development Sep 12, 2022
@sw1nn
Copy link

sw1nn commented Sep 12, 2022 •
edited

The cooling queue is an unbounded LinkedBlockingQueue, but items are placed on the queue with .offer which at least implies there is an expectation in the design that the queue is bounded. I don't have any sage advice on how the cooling queue should be sized however

@refset refset changed the title Second Chance cache should not leak memory Second Chance cache should not leak memory (unconfirmed) Sep 12, 2022
@refset refset moved this from Selected to In progress in XTDB Development Sep 13, 2022
This was referenced Sep 13, 2022
Closed
Merged
@jarohen jarohen moved this from In progress to Backlog in XTDB Development Sep 30, 2022
@jarohen jarohen added the 1.x label Apr 21, 2023
@refset refset changed the title Second Chance cache should not leak memory (unconfirmed) Second Chance cache should not leak memory Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x bug Something isn't working repro-reqd
Projects
1.x
Status: Backlog
XTDB Development
Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jarohen @sw1nn @refset @wotbrew