Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production-ready default Kafka configurations #347

Closed
refset opened this issue Oct 7, 2019 · 2 comments
Closed

Production-ready default Kafka configurations #347

refset opened this issue Oct 7, 2019 · 2 comments
Labels
1.x good first issue Good for newcomers

Comments

@refset
Copy link
Contributor

refset commented Oct 7, 2019

E.g. default :replication-factor should probably be 3 for typical production usage here https://github.com/juxt/crux/blob/69b3078c5c2d0c28c45c6a53f7da7fbb34c26217/crux-core/src/crux/bootstrap.clj#L34 (or wherever this ends up after the config branch is merged #340)

Additionally Confluent Cloud recommends 6 partitions by default, which seems like a sensible default for the document topic. See: https://github.com/juxt/crux/blob/ee310eb5cf153a8b4ad3d8c5764da7aa0bdc0669/docs/example/crux-cloud/README.adoc

There may also be other useful default config options of interest. Somewhat related is the ability to POST to remote Crux nodes for Kafka configuration rather having to think about making .properties files available.

@refset refset added good first issue Good for newcomers analysis labels Oct 7, 2019
@refset refset added this to the Beta milestone Oct 7, 2019
@refset refset added this to To do in XTDB Development via automation Oct 7, 2019
@hraberg
Copy link
Contributor

hraberg commented Oct 7, 2019

When making this change, sanity check that the tests and dev.clj, or rather, anything related to embedded kafka uses a replication factor of 1.

@jarohen jarohen moved this from Selected to Moving to 'Open' in XTDB Development Nov 13, 2019
@jarohen jarohen removed this from Moving to 'Open' in XTDB Development Nov 13, 2019
@jarohen jarohen removed this from the Beta milestone Nov 15, 2019
@jarohen jarohen removed the analysis label Mar 25, 2020
@jarohen
Copy link
Member

jarohen commented Apr 7, 2020

we have these in Soak, let's ensure these are documented as part of #386

@jarohen jarohen closed this as completed Apr 7, 2020
@jarohen jarohen added the 1.x label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants