Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use get_leading_stride more consistently #34

Closed
wolfv opened this issue Aug 29, 2017 · 1 comment
Closed

Use get_leading_stride more consistently #34

wolfv opened this issue Aug 29, 2017 · 1 comment

Comments

@wolfv
Copy link
Member

wolfv commented Aug 29, 2017

The ger implementation should proably use get_leading_stride as well (eventually the other blas functions, too).

https://github.com/QuantStack/xtensor-blas/blob/master/include/xtensor-blas/xblas.hpp#L212-L233
@wolfv wolfv closed this as completed Aug 29, 2017
@wolfv
Copy link
Member Author

wolfv commented Aug 29, 2017

I closed it as ger only works with 1D arrays. But still, for consistency it might be the correct choice to use get_leading_stride

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wolfv