Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make json optional in tests #840

Closed
wolfv opened this issue May 10, 2018 · 1 comment · Fixed by #871
Closed

Make json optional in tests #840

wolfv opened this issue May 10, 2018 · 1 comment · Fixed by #871

Comments

@wolfv
Copy link
Member

wolfv commented May 10, 2018

I think we should activate the tests for json serialization only when nlohmann_json has been found on the system as many people will likely not have it installed.
@SylvainCorlay
Copy link
Member

👍

@wolfv wolfv mentioned this issue May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make json tests optional, bump xtl/xsimd versions wolfv/xtensor
2 participants
@wolfv @SylvainCorlay