Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search addon: Support "match whole word" option #1658

Closed
Tyriar opened this issue Sep 5, 2018 · 2 comments
Closed

Search addon: Support "match whole word" option #1658

Tyriar opened this issue Sep 5, 2018 · 2 comments
Labels
good first issue help wanted type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 5, 2018

When true, a search for "term" would match "a term b" but not "a terms b"

Plan issue: #705

@Tyriar Tyriar added type/enhancement Features or improvements to existing features help wanted addon good first issue labels Sep 5, 2018
@alexr00
Copy link
Contributor

alexr00 commented Sep 6, 2018

It seems like space wouldn't be the only delimiter that signifies the start/end of a word. I'm thinking that anything that isn't a letter or number should be used as a "whole word delimiter".
Examples where "term" would not match:
"a 5term b"
"a term2 b"
Examples where "term" would match:
"a %term b"
"a (term} b"

@Tyriar
Copy link
Member Author

Tyriar commented Sep 8, 2018

@alexr00 👍 I think this is what monaco does as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants