Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in OSC subparsing #2342

Closed
jerch opened this issue Jul 25, 2019 · 0 comments · Fixed by #2346
Closed

error in OSC subparsing #2342

jerch opened this issue Jul 25, 2019 · 0 comments · Fixed by #2346
Assignees
@jerch
Labels
area/parser type/bug Something is misbehaving
Milestone
4.0.0

Comments

@jerch
Copy link
Member

jerch commented Jul 25, 2019

We have an error in OSC identifier parsing, the following sequence is sent by reset:

OSC 104 BEL

Currently our identifier parsing searches for the first ';' as delimiter of the identifier and the payload, thus the sequence above leads to an error message of an unknown OSC command with identifier -1.
@jerch jerch added type/bug Something is misbehaving area/parser labels Jul 25, 2019
@jerch jerch self-assigned this Jul 25, 2019
@jerch jerch mentioned this issue Jul 25, 2019
Merged
4 tasks
@jerch jerch added this to the 4.0.0 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerch jerch

Labels
area/parser type/bug Something is misbehaving
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Parser hooks jerch/xterm.js
1 participant
@jerch