Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligatures addon should depend on the core code base #2896

Closed
Tyriar opened this issue May 3, 2020 · 1 comment
Closed

Ligatures addon should depend on the core code base #2896

Tyriar opened this issue May 3, 2020 · 1 comment
Labels
area/addon/ligatures duplicate type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented May 3, 2020 •
edited
Loading

After #2847, the ligatures addon has been merged into the codebase, however internal changes won't trigger failures in the ligatures addon since it uses MockTerminal for unit tests. We should add some integrated (.api.ts) tests that run in puppeteer and so that breakages will be detected and will fail CI.
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label May 3, 2020
@Tyriar Tyriar mentioned this issue May 3, 2020
Merged
@Tyriar Tyriar mentioned this issue May 3, 2020
Open
@Tyriar
Copy link
Member Author

Tyriar commented Oct 19, 2021

duplicate of #958

@Tyriar Tyriar closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addon/ligatures duplicate type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar