Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The height cannot be changed #2988

Closed
RanX12 opened this issue Jul 4, 2020 · 2 comments
Closed

The height cannot be changed #2988

RanX12 opened this issue Jul 4, 2020 · 2 comments

Comments

@RanX12
Copy link

RanX12 commented Jul 4, 2020

Hello, after I call the fit() method, the width has changed and the height cannot be changed. Why is it always 600px?

Details

  • Browser and browser version: chrome 83.0.4103.116
  • OS version: Mac 10.12.6
  • xterm.js version: 4.6.0

Steps to reproduce

Create a new xterm, output multiple lines of code, the height is fixed at 600px, can not adapt, the fit() method has been used

@RanX12
Copy link
Author

RanX12 commented Jul 4, 2020

I am using xterm-addon-fit

@jerch
Copy link
Member

jerch commented Jul 4, 2020

Plz have a look at the source code of the fit addon to understand what it does.

In short:
It does not change the geometry of your visual terminal container - it does the opposite adjusting cols and rows, so the terminal content fits into your container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants