Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test script seriously broken #3326

Closed
jerch opened this issue May 10, 2021 · 3 comments
Closed

integration test script seriously broken #3326

jerch opened this issue May 10, 2021 · 3 comments
Labels
important type/debt Technical debt that could slow us down in the long run

Comments

@jerch
Copy link
Member

jerch commented May 10, 2021 •
edited

#2714 introduces several changes to the integration tests and how they get launched:

  • always starts new server
  • changed port to 3001

There are several issues with the new script, esp. if you want to use it locally:

  • swallows errors (no feedback at all)
  • server gets not always teared down
  • port is blocked in next run exiting at server startup
  • returns with a success returncode on next run without executing ANY test case, WTH?
  • fast test case driven development is almost impossible now (server startup takes >3s)

This needs serious rework to work again, at least with proper state handling of the server process.
@jerch jerch added the type/debt Technical debt that could slow us down in the long run label May 10, 2021
@Tyriar
Copy link
Member

Tyriar commented May 10, 2021

Oh 🤦 this is why I was using CI to test in #3317

@Tyriar Tyriar added this to the 4.12.0 milestone May 10, 2021
@Tyriar Tyriar modified the milestones: 4.12.0, 4.13.0 May 10, 2021
@Tyriar Tyriar modified the milestones: 4.13.0, 4.14.0 Jun 24, 2021
@Tyriar Tyriar mentioned this issue Sep 3, 2021
Closed
3 tasks
@Tyriar Tyriar modified the milestones: 4.14.0, 4.15.0 Sep 9, 2021
@meganrogge meganrogge modified the milestones: 4.15.0, 4.16.0 Nov 5, 2021
@Tyriar
Copy link
Member

Tyriar commented Dec 22, 2021

Playwright test PR still in progress in #3460, moving to next milestone since we're releasing soon

@Tyriar Tyriar modified the milestones: 4.16.0, 4.17.0 Dec 22, 2021
@Tyriar Tyriar removed this from the 4.17.0 milestone Feb 3, 2022
@Tyriar Tyriar mentioned this issue Aug 27, 2023
Merged
@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2023

Think this is fixed now

@Tyriar Tyriar closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adopt @playwright/test and improve integration tests Tyriar/xterm.js
3 participants
@Tyriar @jerch @meganrogge