Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emojis with skin tone #3397

Open
Tyriar opened this issue Jul 27, 2021 · 4 comments
Open

Support emojis with skin tone #3397

Tyriar opened this issue Jul 27, 2021 · 4 comments
Labels
area/parser type/enhancement Features or improvements to existing features

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 27, 2021

From @pcgeek86 in microsoft/vscode#129470

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.58.2
  • OS Version: Windows 10 Build 21387

Steps to Reproduce:

  1. Run Python 3 in VSCode Integrated Terminal
  2. Paste code below
mystr = ''
for x in [0x1F442, 0x1F3FC]:
  mystr += str(chr(x))

print(mystr)
print('👌🏻')

Here's how VSCode Integrated Terminal renders it:

image

Here's what it (correctly) looks like in Microsoft Terminal (albeit it has a whitespace issue):

image

Expected Result

Emojis with skin tones should be rendered with the specified string.

Actual Result

Emojis with skin tones are rendered as two separate characters.

@PerBothner
Copy link
Contributor

This is related to handling of Extended Grapheme Clusters. See this comment about how Domterm handles clusters.

@starball5
Copy link

Does this issue ticket cover other similar issues like https://stackoverflow.com/q/77425006/11107541 or should a new issue ticket be raised for that?

@PerBothner
Copy link
Contributor

I believe this can be closed, now that PR #4519 has been merged.

You need to enable the unicode-graphemes addon.

@starball5
Copy link

@Tyriar Does VS Code yet have an issue ticket about enabling the unicode-graphemes addon? If you create one / know of one, can you please ping me with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/parser type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

3 participants