xterm-addon-web-links IViewportRange in hover callback is offset by 1

[Coding-Kiwi]

I have a line with a link:

Its the first line (row) of the terminal.

When I select something in the line and call terminal.getSelectionPosition, the start and end row is 0, this is what I would expect
When I hover the link and receive the location from the WebLinkProvider hover callback the start and end row is 1

Details

• Browser and browser version: Electron 21.2.0
• OS version: Windows 11
• xterm.js version: 5.0.0
• xterm-addon-web-links 0.7.0

Steps to reproduce

1. have a line with text and link
2. have xterm-addon-web-links with hover callback
3. select text, call getSelectionPosition
4. hover link, receive location
5. compare rows of locations

[Tyriar]

I'd expect this is 0-based but following IBufferRange says it should be 1-based:

xterm.js/typings/xterm.d.ts

Lines 1244 to 1272 in 4451369

	/**
	* A range within a buffer.
	*/
	interface IBufferRange {
	/**
	* The start position of the range.
	*/
	start: IBufferCellPosition;
	/**
	* The end position of the range.
	*/
	end: IBufferCellPosition;
	}
	/**
	* A position within a buffer.
	*/
	interface IBufferCellPosition {
	/**
	* The x position within the buffer (1-based).
	*/
	x: number;
	/**
	* The y position within the buffer (1-based).
	*/
	y: number;
	}