-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
;
inside the URL breaks the OSC hyperlink
#4944
Comments
Before fixing this we should verify that |
@Tyriar https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#encodings states, that additional uri params may not contain |
Cool, I suspected that might be the case. Closing as designed then |
@Tyriar @jerch https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#the-escape-sequence Without support for ; there are plenty of valid URI's that cannot be linked |
@schaffino makes sense, thanks for the follow up. I read the "additional parameters" part wrong. |
Eww, seems I also misread that. |
Attempted a fix here: #5003 |
Tried this in both VSCode and Jupyterlab. It seems the OSC hyperlink integration doesn't work properly when the linked URL contains a ';'
The following submitted to terminator terminal emulator results in a link directing me to https://www.example.com/query;arg=1;arg=2;arg=3
printf '\e]8;;https://www.example.com/query;arg=1;arg=2;arg=3\e\\This is a link\e]8;;\e\\n'
Running the same in jupyter or VSCode, I end up being redirected to https://www.example.com/query, with the arguments truncated
Details
Steps to reproduce
The text was updated successfully, but these errors were encountered: