Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal links with mixed styles don't work #654

Closed
Tyriar opened this issue May 5, 2017 · 3 comments
Closed

Terminal links with mixed styles don't work #654

Tyriar opened this issue May 5, 2017 · 3 comments
Labels
type/bug Something is misbehaving
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 5, 2017

VS Code issue: microsoft/vscode#25991
@Tyriar Tyriar added the type/bug Something is misbehaving label May 5, 2017
@Tyriar Tyriar mentioned this issue May 5, 2017
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jun 9, 2017

This also happens when the cursor is in the middle of a link as the cursor is a top-level span:

screen shot 2017-06-09 at 11 42 16 am

This was referenced Jun 19, 2017
Closed
Closed
Closed
@Tyriar Tyriar mentioned this issue Jul 6, 2017
Closed
6 tasks
@lucat1
Copy link
Contributor

lucat1 commented Sep 8, 2017

Is this still reproducible with the new render?

@Tyriar
Copy link
Member Author

Tyriar commented Sep 10, 2017

Yep, no more dealing with DOM nodes 😃

@Tyriar Tyriar closed this as completed Sep 10, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Sep 10, 2017
@Tyriar Tyriar mentioned this issue Sep 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Tyriar @lucat1