Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm-bold is being added when bold font widget differs #730

Closed
Tyriar opened this issue Jun 26, 2017 · 0 comments
Closed

xterm-bold is being added when bold font widget differs #730

Tyriar opened this issue Jun 26, 2017 · 0 comments
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2017

See microsoft/vscode#29402 (comment)

It seems that if the bold broken logic runs when the terminal is detected from the DOM or not visible it will break it for the life of the terminal as it's only measured once. We should do a better job of re-evaluating broken bold state when the font changes and to redo it later if the terminal is not in the right state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

1 participant