Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First row of alt buffer is drawn incorrectly in some situations #947

Closed
mofux opened this issue Sep 5, 2017 · 1 comment
Closed

First row of alt buffer is drawn incorrectly in some situations #947

mofux opened this issue Sep 5, 2017 · 1 comment
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@mofux
Copy link
Contributor

mofux commented Sep 5, 2017

Editing a file in mc and scrolling (either with scroll wheel or using the arrow keys) renders the first row of the screen incorrectly:
mcedit

This bug was likely introduced by #855 and tried to fix by #923 without success. Note It does only happen on the v3 branch, not master.

To reproduce, install mc brew install mc, then in the demo mcedit lib/Terminal.js and scroll using the wheel or alt+down and alt+up

@mofux
Copy link
Contributor Author

mofux commented Sep 7, 2017

Trying to shed some light into this issue.

mcedit showing the file
screen shot 2017-09-07 at 15 33 39

Then pressing alt+down to scroll down one line in the file produces the following
screen update sequence from the TTY:

[39m[49m[2;23r[2;1H[1M[1;24r[1;35H[30m[46m2[6C2[9C4[14C32[5C0[23;1H[37m[44mimport { Buffer } from './Buffer';                                               [2;1H

which translates to:

// only use row 2-23 for scroll (`[2;23r`)
InputHandler.setScrollRegion(2,23)
// use full screen for scroll (`[1;24r`)
InputHandler.setScrollRegion(1,24)

and finally ends in this state:
screen shot 2017-09-07 at 15 34 05

@mofux mofux added the type/bug Something is misbehaving label Sep 7, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Sep 7, 2017
@mofux mofux closed this as completed in #952 Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants