Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide binaries for download on GitHub Releases #1

Closed
probonopd opened this issue Feb 9, 2018 · 8 comments
Closed

Please provide binaries for download on GitHub Releases #1

probonopd opened this issue Feb 9, 2018 · 8 comments

Comments

@probonopd
Copy link

https://github.com/xtools-at/Electron-PWA-Wrapper/blob/6e7e5b1ea2aad3c5f49eda09f91724f58d4e2bde/README.md#build-for-linux-any-distro-using-appimage describes how to build an AppImage. Can you please provide one on https://github.com/xtools-at/Electron-PWA-Wrapper/releases so that users don't have to build it themselves? Thanks.

@xtools-at
Copy link
Owner

What's that good for? You have to customise a lot of the code first to make it fit your own web app, why should there be a prebuilt release of the example app?

There's a repo where I put the releases of the Leasingrechnen.at app:
https://github.com/xtools-at/Leasingrechner-Releases
But the Linux app is not ready yet, app icons are still buggy.

@probonopd
Copy link
Author

Yes, I think it's always good to have default examples to test before one has to compile something. Thanks.

@xtools-at
Copy link
Owner

xtools-at commented Feb 10, 2018

Ok, I'll add the Release repo to the README - still, I don't think that compiling is that hard here, it's literally 3 commands (git clone, npm i, npm run build), if one's working with Linux, one should be able to do that 😁

@xtools-at
Copy link
Owner

xtools-at commented Feb 10, 2018

Here we go, I've added the repo to the Release Notes of 1.1 beta.

Btw, if you manage to solve the App- and Tray-Icon issue on Linux, a Pull Request would be much appreciated!

@probonopd
Copy link
Author

Thanks @xtools-at but where exactly do I find the AppImage for download? (Am I blind?)

@xtools-at xtools-at reopened this Feb 10, 2018
@xtools-at
Copy link
Owner

xtools-at commented Feb 10, 2018

But the Linux app is not ready yet, app icons are still buggy.

I didn't upload a build since it's not ready yet (see #3 ). I've dropped you my latest Dev-Version on Drive.

@xtools-at
Copy link
Owner

xtools-at commented Feb 10, 2018

just compiled a new version for testing a fix with #3 - I've updated the link and comment above.
the compiled AppImage will be added to the Releases-Repo once it's done.

@xtools-at
Copy link
Owner

Will be adding a working Linux version within the next 30min to the release-repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants