Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program keeps overwriting already downloaded files #5

Closed
Akashic101 opened this issue Jan 19, 2020 · 7 comments
Closed

Program keeps overwriting already downloaded files #5

Akashic101 opened this issue Jan 19, 2020 · 7 comments

Comments

@Akashic101
Copy link

When using
hbd --progress

I noticed that it continues downloading 1epub, 1.cbz and 1.pdf and continues to overwrite those files as seen here: https://i.imgur.com/saHpqIx.png and this is the download-location: https://i.imgur.com/oDYfBWn.png

@Silvenga
Copy link

I can confirm this, for example,

Shelter 2 has three downloads:

Downloading: Shelter 2.zip: 100% [==================================================]
Downloading: Shelter 2.zip: 100% [==================================================]
Downloading: Shelter 2.zip: 100% [==================================================]

And comparing this against Humble Bundle:

image

There are three platforms, each one with a different zip file.

It appears that hbd is overriding duplicate downloads.

@Silvenga
Copy link

This appears to be actually very common:

image

@xtream1101
Copy link
Owner

Ah, I have not seen this yet. I will find something that does this and seems the best thing to do will be to name it like:
Shelter 2 [Mac].zip
Shelter 2 [Linux].zip
Shelter 2 [Windows].zip

Would that work for everyone?

@azuravian
Copy link

Another related issue is with PDFs and HD PDFs. I am currently limiting to specific filetypes and downloading epub, pdf, and cbz. For PDFs, it downloads both the HD and the standard PDF and names them the same, therefore overwriting the HD version with the standard version.

@xtream1101
Copy link
Owner

@azuravian can you share a screen shot of the download section for that bundle like the one above. I would like to see how they show the difference between a pdf and an hd pdf.

@tjwlucas
Copy link

Also the same with audio Zips (e.g. FLAC/mp3)

@xtream1101
Copy link
Owner

Ok, so since there are so many different cases, it seems the best option is to have the original download name be used for the actual file. I realized that this will not be to bad since all the files are still grouped under the same folder which has a nice human readable name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants