You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've hooked up FCMDeviceAuthorizedViewSet to Django REST framework using DefaultRouter as described in the manual, and configured my app to POST to my base URL /api/fcm/. Registration seems to be working nicely, except for the fact that the creation view by FCMDeviceAuthorizedViewSet seems to allow for the same device ID to be registered to the same user again, even if the registration token is identical.
The manual states "Will allow duplicate registration_id’s for different users, so you are responsible for cleanup (if that is generally perceived as undesired behaviour or if the package itself should be doing the cleanup, open an issue or email me)". It seems that the most logical behavior would be to allow one user to register multiple unique device IDs, and only update the registration_token for existing device IDs.
The text was updated successfully, but these errors were encountered:
I've come to the conclusion that this is a downstream side effect of #53. I've submitted a PR that addresses that issue as well as fixed a couple of logic errors that were causing everyone else's tokens to be set to inactive.
I've hooked up FCMDeviceAuthorizedViewSet to Django REST framework using DefaultRouter as described in the manual, and configured my app to POST to my base URL
/api/fcm/
. Registration seems to be working nicely, except for the fact that the creation view by FCMDeviceAuthorizedViewSet seems to allow for the same device ID to be registered to the same user again, even if the registration token is identical.The manual states "Will allow duplicate registration_id’s for different users, so you are responsible for cleanup (if that is generally perceived as undesired behaviour or if the package itself should be doing the cleanup, open an issue or email me)". It seems that the most logical behavior would be to allow one user to register multiple unique device IDs, and only update the registration_token for existing device IDs.
The text was updated successfully, but these errors were encountered: