Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM_DJANGO_SETTINGS can't be overridden in tests #83

Open
ziima opened this issue Dec 19, 2018 · 2 comments
Open

FCM_DJANGO_SETTINGS can't be overridden in tests #83

ziima opened this issue Dec 19, 2018 · 2 comments

Comments

@ziima
Copy link
Contributor

ziima commented Dec 19, 2018

Django provide standard way to override settings with override_settings decorator. Sadly this doesn't work for FCM_DJANGO_SETTINGS.

@ziima ziima changed the title FCM_DJANGO_SETTINGS can't be overrided in tests FCM_DJANGO_SETTINGS can't be overridden in tests Dec 19, 2018
@xtrinch
Copy link
Owner

xtrinch commented May 14, 2019

Could anyone perhaps help us with a pull request?

@xtrinch xtrinch closed this as completed May 14, 2019
@xtrinch xtrinch reopened this May 14, 2019
@Andrew-Chen-Wang
Copy link
Contributor

Temporarily you can try this: https://stackoverflow.com/a/58726299

But the only solution for the package itself is to not use dictionary based settings. That'd require a new major version. Thing is; for many packages that have values that shouldn't exactly be overridden simply for tests (like this package or allauth's social providers), a temporary solution like the one provided in the SO link is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants