add more tests

JuliaML · Sep 20, 2019 · 4cd4e23 · 4cd4e23
1 parent 8f2112f
commit 4cd4e23
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/moment_matching.jl b/src/moment_matching.jl
@@ -77,12 +77,15 @@ function _estimate_ratio(mmd::MMDNumerical, Kdede, Kdenu)
     return value.(r)
 end
 
-struct MMDAnalytical{T,S,M} <: AbstractMMD
+struct MMDAnalytical{T<:AbstractFloat,S,M} <: AbstractMMD
     ϵ::T
-    function MMDAnalytical(; ϵ::T=1f-3, method::Symbol=:solve) where {T<:AbstractFloat}
+    function MMDAnalytical(; ϵ::T=1f-3, method::Symbol=:solve) where {T}
         @assert method in (:solve, :inv)
         S = iszero(ϵ) ? Val{:false} : Val{:true}
-        new{T, S, Val{method}}(ϵ)
+        if T == Int
+            ϵ = float(ϵ)
+        end
+        new{eltype(ϵ), S, Val{method}}(ϵ)
     end
 end
 

diff --git a/test/moment_matching.jl b/test/moment_matching.jl
@@ -74,6 +74,11 @@ end
 
         r_solve = estimate_ratio(MMDAnalytical(method=:solve), x_de, x_nu)
         r_inv = estimate_ratio(MMDAnalytical(method=:inv), x_de, x_nu)
+
+        @test r_solve ≈ r_inv
+
+        r_solve = estimate_ratio(MMDAnalytical(ϵ=0), x_de, x_nu)
+        r_inv = estimate_ratio(MMDAnalytical(ϵ=0), x_de, x_nu)
 
         @test r_solve ≈ r_inv
     end