Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make FAML running #13

Closed
xulabs opened this issue Aug 6, 2019 · 10 comments
Closed

make FAML running #13

xulabs opened this issue Aug 6, 2019 · 10 comments
Assignees
Labels
ToDo Functionality

Comments

@xulabs
Copy link
Owner

xulabs commented Aug 6, 2019

entry function
aitom.average.ml.faml.faml.test_EM_real_data

The method is based on the following paper:

Zhao Y, Zeng X, Guo Q, Xu M. An integration of fast alignment and maximum-likelihood methods for electron subtomogram averaging and classification. ISMB 2018. Bioinformatics. 2018 Jul 1; 34(13): i227–i236. doi:10.1093/bioinformatics/bty267. arXiv:1804.01203

Let's first fix the bugs to make the program run.

@ijinjay for technical questions, can consult with @xiangruz .

@xulabs xulabs added the ToDo Functionality label Aug 6, 2019
@ijinjay
Copy link
Contributor

ijinjay commented Aug 12, 2019

  1. io.db.lsm_db not found
  2. tomominer_mbc not found
  3. statistics.vol not found
  4. pls provide some image data for FAML

@xiangruz @xulabs

@xulabs
Copy link
Owner Author

xulabs commented Aug 15, 2019

added statistics.vol and lsm_db

@ijinjay
Copy link
Contributor

ijinjay commented Aug 17, 2019

@xiangruz Pls add image db data for FAML. 😃

@xiangruz
Copy link
Contributor

@ijinjay I added database preparation commands into the faml tutorial.

@ijinjay
Copy link
Contributor

ijinjay commented Aug 18, 2019

Pls add fast_rotation_align function in align.fast.util. 😃

@xulabs
Copy link
Owner Author

xulabs commented Aug 18, 2019

added to align.fast.util.fast_rotation_align()
moved align.util to align.fast.util

@ijinjay
Copy link
Contributor

ijinjay commented Aug 20, 2019

test_EM_real_data(img_data, 20, 2, 5, "output")
got RuntimeError: v2.max() == v2.min() in tomominer.core.core.rot_search_cor()
Is there any error in the sample data or the code?

@xulabs
Copy link
Owner Author

xulabs commented Aug 20, 2019

@ijinjay this is normally because v2 has only a single value across the whole array. So it is invalid for alignment.
@xiangruz can you check the data?

@ijinjay
Copy link
Contributor

ijinjay commented Aug 28, 2019

m2 = np.ones((n, n, n))

m2 = np.ones((n, n, n))

Before align.fast_align(v1, m1, v2, m2), m2 is assigned ones in the above lines, which causes the bugs. Pls fix it. @xiangruz

@xiangruz
Copy link
Contributor

Fixed the problem with fast_align

@xulabs xulabs mentioned this issue Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ToDo Functionality
Projects
None yet
Development

No branches or pull requests

3 participants