Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift of the text box when the percent is not 100% #459

Closed
xulihang opened this issue Jul 8, 2023 · 3 comments
Closed

Shift of the text box when the percent is not 100% #459

xulihang opened this issue Jul 8, 2023 · 3 comments

Comments

@xulihang
Copy link
Owner

xulihang commented Jul 8, 2023

ImageTrans uses int to store the geometry of a text box while the actually views use double which causes shift of the text box when switching display percentage or re-rendering the text after manual adjusting.

Video:

ice_video_20230708-160405.mp4
ice_video_20230708-160653.mp4
@xulihang
Copy link
Owner Author

xulihang commented Jul 8, 2023

I decided to save the geometry in double to avoid such a problem.

After:

ice_video_20230708-160845.mp4
ice_video_20230708-160930.mp4

@xulihang
Copy link
Owner Author

xulihang commented Jul 9, 2023

Fixed in v2.1.0.

@xulihang xulihang closed this as completed Jul 9, 2023
@xulihang
Copy link
Owner Author

xulihang commented Jul 9, 2023

If the target geometry is using double, it may cause a blurry text image, so I decided not to use double. The inconsistent problem is fixed by using the target geometry stored in the project file instead of using the views' size and position values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant